[bug] *renamed* staff can interact with switches, buttons, doors and pressure plates while in staff mode

[heathfx]

When a staff member is in staff mode with fly enabled and they use random teleport, fly will be disabled if the random teleport changes the dimension between the overworld and the nether.

The only way to get fly back is to exit and re-enter fly mode.

[garagepoort]

Thanks @heathfx, good catch I will look into this. Hopefully I can fix this by next release.

[heathfx]

This has been around since the old staff+ days, my workaround was to set staff mode in creative, but it was a pain for interacting with player inventories. It is possible that worldguard is clearing fly mode, but it would be good for staff++ to check this every time the staff member changes worlds to make sure it is still active.

Also, another related issue to random teleport, sometimes the ender eye in the gui actually gets thrown and then players find eyes named "teleport to random player" and sometimes a staff member is able to interact with a door by spam clicking it in staff mode. It's really important that staff cant interact with the world like this because it will give away their presence, defeating the purpose of total vanish. this issue also has been around since staff+

[heathfx]

oops. You can dis-regard this, essentials is screwing with fly mode on dimension change. adding essentials.fly to my staffmode permission group resolved the issue.

The other issue with throwing the ender eye and door interaction remains.

[garagepoort]

HEy @heathfx I fixed the endereye issue. About the door thing I'm a bit unsure because it seems like a feature from the old Staff+. The reason you can't sometimes interact with it is because your holding staff item. If for example your hand would be empty you can always open the door. Some people might not like it if I disable any interaction while in staff/vanish mode.

I'll probably add a property to disable any interaction while in vanish

[heathfx]

If the resulting interaction with doors can be made silent, then that would be one approach...the other would be a gui option to toggle spectator mode so you could just clip through the wall. for now I added an alias for /gamemode spectator (/sp) and /gamemode survival (/su) and set staffmode permissions to allow changing gamemode only while in staffmode.