django-emoji icon indicating copy to clipboard operation
django-emoji copied to clipboard

Make sure the version variable in Javascript is actually used

Open gaqzi opened this issue 10 years ago • 1 comments

From the inception of this library the idea was that if there were to be any changes in the emoji library/javascript code then the frontend cache would get reloaded silently.

This was to be handled by a numerical version handled by the core Emoji library.

Before the release of 1.1 the changes that needs to be done is:

  • setDataUrl will have to take a version parameter which is the Emoji internal version number as well as a user local version that will just be tacked on.
  • The version comparison is a strict string comparison (storedVersion === currentVersion)
  • When the version doesn't match then reload the emoji database from the server

gaqzi avatar Mar 13 '14 05:03 gaqzi

is this still needed with agressive caching and serviceworkers?

jrabbit avatar Jul 13 '18 00:07 jrabbit