gap icon indicating copy to clipboard operation
gap copied to clipboard

Use `LoadKernelExtension` and `IsKernelExtensionAvailable` in more packages

Open fingolfin opened this issue 1 year ago • 11 comments

These function have been available since GAP 4.12.0 and I think we should use them in more (ideally all) packages with kernel extension. So far only edim and browse do so.

Here is a list of affected distributed packages. The goal would be to either submit an issue or a PR to each of these over time.

  • [x] cddinterface: https://github.com/homalg-project/CddInterface/pull/43, done in v2024.08.27
  • [x] crypting: https://github.com/gap-packages/crypting/pull/24, done in v0.10.5
  • [x] curlinterface: https://github.com/gap-packages/curlInterface/pull/52, done in v2.4.0
  • [x] cvec: https://github.com/gap-packages/cvec/pull/45
  • [x] datastructures: https://github.com/gap-packages/datastructures/pull/153
  • [x] deepthought: https://github.com/gap-packages/DeepThought/pull/21
  • [x] digraphs: https://github.com/digraphs/Digraphs/pull/668, done in v1.9.0
  • [x] ferret: https://github.com/gap-packages/ferret/pull/61
  • [x] float: https://github.com/gap-packages/float/pull/94
  • [x] gauss: https://github.com/homalg-project/homalg_project/pull/614
  • [ ] hap: https://github.com/gap-packages/hap/issues/123
  • [x] io: https://github.com/gap-packages/io/pull/125, done in v4.9.0
  • [x] json: https://github.com/gap-packages/json/pull/33
  • [x] normalizinterface: https://github.com/gap-packages/NormalizInterface/pull/117
  • [x] orb: https://github.com/gap-packages/orb/pull/69
  • [x] profiling: https://github.com/gap-packages/profiling/pull/118
  • [ ] semigroups: https://github.com/semigroups/Semigroups/pull/1032
  • [x] zeromqinterface: https://github.com/gap-packages/ZeroMQInterface/pulls

fingolfin avatar Jul 03 '24 12:07 fingolfin

Some of us at GAPDays are going to work on this today.

james-d-mitchell avatar Aug 26 '24 10:08 james-d-mitchell

I'm going to make a start on semigroups

Joseph-Edwards avatar Aug 26 '24 10:08 Joseph-Edwards

I will take json.

limakzi avatar Aug 26 '24 10:08 limakzi

Working on cvec now.

Joseph-Edwards avatar Aug 26 '24 11:08 Joseph-Edwards

Working on orb. https://github.com/gap-packages/orb/pull/69

limakzi avatar Aug 26 '24 12:08 limakzi

Working on ferret.

Joseph-Edwards avatar Aug 26 '24 12:08 Joseph-Edwards

Thanks for the efforts, folks. A general comment: I think it is fine to just change all these packages to require GAP >= 4.12. After all: not many people will update a single package; most just update all of GAP at once. (This might change in the future if PackageManager gets more widely used but I don't think we are there yet, so we don't need to worry about it.

If you do it that way, then also update .github/workflows/CI.yml to not test against older (now unsupported) GAP versions.

fingolfin avatar Aug 26 '24 12:08 fingolfin

@fingolfin Lets take it as definition of done, if so. I'm fully OK with that. By the way, working on gauss. ;)

Pull-request: https://github.com/homalg-project/homalg_project/pull/614.

limakzi avatar Aug 26 '24 12:08 limakzi

Doing float now

Joseph-Edwards avatar Aug 26 '24 13:08 Joseph-Edwards

https://github.com/gap-packages/hap/issues/123

limakzi avatar Aug 26 '24 13:08 limakzi

Just to say: it might be a bit premature to mark a package as "fixed" in the list at the top of this issue right after the corresponding PR was merged: in my eyes it is only truly "fixed" if there also is a release of that package with the changes.

fingolfin avatar Aug 26 '24 22:08 fingolfin

Resolved from my POV (hap is a special case as explained on the linked issue there)

fingolfin avatar Jan 14 '25 00:01 fingolfin