Gaojie Liu

Results 12 comments of Gaojie Liu

Looks good to me and I am going to merge it and cut a new release. Thanks for the fix!

New release is out: https://github.com/linkedin/avro-util/releases/tag/0.4.17

@volauvent For primitive list, the big benefit is totally reasonable. But for the primitive type for each field, we may need to do another round of benchmark to understand the...

@oleg-smith Can this be done by adding string annotations to the reader schema instead of updating the serde since fast-avro is trying to align with the standard avro implementation?

@oleg-smith If you want to use Java String type for the regular `string` type, you could put additional annotation like this way: ``` "type": { "type": "string", "avro.java.string": "String" }...

@oleg-smith The fast-avro class is generated from the schema string/file, so how come you don't have access to the schema file? Inside the application, before generating fast classes, I think...

@oleg-smith https://github.com/linkedin/avro-util/blob/master/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/FastSerdeCache.java#L355 Here is the method to generate a fast specific class synchronously. Regarding supporting specific CharSequence impl override in fast-avro, I think a utility to add right string annotation...

yeah, it is a public method in `FastSerdeCache`.

I see. Such method doesn't exist today, and feel free to add them in `FastSerdeCache` and it should be fairly straightforward.