Et-Futurum icon indicating copy to clipboard operation
Et-Futurum copied to clipboard

Messing up Mystcraft baseline profiling.

Open wmrojer opened this issue 8 years ago • 2 comments

The WorldTickEvent handler that upgrades old tile enties with the new upgraded version puts a lot of stress on the server making Mystcraft baseline profiling almost impossible to be complete. With some other mods loaded the game will crash with java.lang.OutOfMemoryError even with 8GB of memory allocated. I have confirmed this by compiling a special version of Et Futurm with the WorldTickEvent handler disabled and then it works fine.

Scanning all loaded tile entites every world tick is NOT a good idea.

This replacement should probably be done at chunk load or as a replacement of the original tiles in the registry. At least make this replacement configurable.

wmrojer avatar Jun 05 '16 10:06 wmrojer

Made a pull request #83 with the replacement configurable.

wmrojer avatar Jun 05 '16 10:06 wmrojer

In my fork of Et Futurum I changed this a little bit and plan on adding further options that involve replacing the blocks in the registry directly too.

I also made it so it only scans the TE list when it gets updated.

Roadhog360 avatar May 21 '21 09:05 Roadhog360