gantry5 icon indicating copy to clipboard operation
gantry5 copied to clipboard

Joomla 4.3 menu params not loaded for new item

Open Flowman opened this issue 1 year ago • 4 comments

In Joomla 4.3 this row no returns a string and not null when a new menu object is created.

https://github.com/gantry/gantry5/blob/95725fbbebbfe923c8744ea04298c097ac92ff0f/platforms/joomla/plg_system_gantry5/gantry5.php#LL635C29-L635C29

Easy fix is to change it to empty() instead of === null.

Joomla 4.3 changes it from null to string here: https://github.com/joomla/joomla-cms/blob/c3593e96dc68b67df3337c2f0caa2ba2dcbdf05e/administrator/components/com_menus/src/Model/ItemModel.php#L582

Flowman avatar May 23 '23 01:05 Flowman

Hey @Flowman, when actually are you experiencing this? I'd love to recreate the issue.

hexplor avatar May 23 '23 09:05 hexplor

Just create a new menu item and the gantry tab is missing.

Flowman avatar May 23 '23 11:05 Flowman

Just create a new menu item and the gantry tab is missing.

I tried to create menu items on both Joomla Menu manager and gantry menu manager and didn't experience any issues. Can you please provide step-by-step instruction to recreate that error?

hexplor avatar May 25 '23 10:05 hexplor

If you change any of the filter options here

image

Then parent_id will be empty string instead of null. So the fix I posted is required if someone by mistake touches the filters.

Flowman avatar May 30 '23 12:05 Flowman