Ganpat Agarwal
Ganpat Agarwal
Thanks @alafanechere 👍 I have updated with master branch and no errors on acceptance test !!
# unit tests run ``` Results (4.97s): 72 passed Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- source_amazon_ads/__init__.py 2 0 100% source_amazon_ads/constants.py 1 0 100% source_amazon_ads/schemas/__init__.py 8 0 100% source_amazon_ads/schemas/attribution_report.py 21 0...
# acceptance test run ``` Test session starts (platform: darwin, Python 3.9.11, pytest 6.2.5, pytest-sugar 0.9.5) cachedir: .pytest_cache hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/ganpatagarwal/stoke/airbyte/airbyte-integrations/connectors/source-amazon-ads/.hypothesis/examples') rootdir: /Users/ganpatagarwal/stoke/airbyte, configfile: pytest.ini plugins: sugar-0.9.5, requests-mock-1.9.3,...
@monai - updated spec to be of enum type - added tests for video report with custom record type `asins`
@monai I have added the requested changes. PTAL
@sajarin @monai @grubberr PTAL
Kindly inform if we are still considering this PR. Thanks
@marcosmarxm please let me know if there are any action points on me for this PR. Thanks !!
Anyone, please run the tests for this PR