Ganpat Agarwal

acceptance test is failing from `master` branch as well. ```――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― TestDiscovery.test_additional_properties_is_true[inputs0] ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― self = discovered_catalog = {'GET_AMAZON_FULFILLED_SHIPMENTS_DATA_GENERAL': AirbyteStream(name='GET_AMAZON_FULFILLED_SHIPMENTS_DATA_GENERAL', json...fresh'>], source_defined_cursor=None, default_cursor_field=None, source_defined_primary_key=None, namespace=None), ...} def test_additional_properties_is_true(self, discovered_catalog: Mapping[str, Any]): """Check...

acceptance tests are fixed now ``` python -m pytest integration_tests -p integration_tests.acceptance Test session starts (platform: darwin, Python 3.9.11, pytest 6.1.2, pytest-sugar 0.9.4) cachedir: .pytest_cache rootdir: /Users/ganpatagarwal/stoke/airbyte, configfile: pytest.ini plugins:...

Need help with acceptance tests. With my version of `secrets/config.json` file, it's stuck after reaching 70%. Looks like tests are based for a specific ads account. ``` python -m pytest...

@YiyangLi The amazon ads account I am using for testing is not given me any issues to fetch attribution report. We had been using the attribution feature on that account...

@YiyangLi I started executing acceptance test iteratively on my local env. **First Error** ``` ------------------------------------------------------------------------------------- Captured log call -------------------------------------------------------------------------------------- ERROR root:test_core.py:376 The sponsored_display_campaigns stream has the following schema errors: 163170956955202...

Done !!

Thanks for the review @monai 👍 I have made the changes. Request to please review again.

I am not sure if above change should fall under this PR. Would it be possible for a maintainer to raise that PR and quickly merge?

removed `additionalProperties` attribute

Any pointers on how to fix this error ``` ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― TestDiscovery.test_backward_compatibility[inputs0] ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― self = , skip_backward_compatibility_tests = False discovered_catalog = {'GET_AMAZON_FULFILLED_SHIPMENTS_DATA_GENERAL': AirbyteStream(name='GET_AMAZON_FULFILLED_SHIPMENTS_DATA_GENERAL', json...fresh'>], source_defined_cursor=None, default_cursor_field=None, source_defined_primary_key=None, namespace=None), ...} previous_discovered_catalog =...