Ganesh Pawar

Results 41 comments of Ganesh Pawar

@alya Fixed the issue. Ready for review.

> Thanks! > > We should make the Cancel / Invite buttons part sticky, like it currently is, so that you can always see it even in short windows. #23033...

> @ganpa3 ca you rebase the PR? It would also possibly need some CSS changes since we have removed some bootstrap CSS rules. Rebased the PR. Ready for review.

@sahil839 Made the changes. Ready for review.

> Looks good to me overall. I guess we can remove `static/templates/invite_user.hbs` file now and also there is some unused CSS for `#invite-user-link` which does not exist anymore. Would be...

> I think this was discussed on another PR, but the big regression from my perspective is that the buttons at the bottom are not sticky. This will be fixed...

> Hm, it looks like the changes didn't get pushed? Pushed the changes. Ready for review.

@timabbott Replied to the above comments and rebased. Ready for review.

> The screenshots above look good to me! Just to check, can you also post screenshots for light theme? Thanks! Done.

@sahil839 Thanks for the suggestion. Updated the PR. @timabbott Ready for review.