Ganesh Pawar

Results 41 comments of Ganesh Pawar

@alya I implemented an initial prototype of this. Ready for your review.

> Cool! Just looking at the GIF so far, let's change the button to "Add streams", and the modal heading to "Add default streams". Done. > Would it be easy...

> I'll retest when the PR passes tests (or let me know if there's some unrelated reason why tests are failing). Thanks! It's failing because I haven't written new tests...

@alya Fixed the above issues, and updated the PR. Ready for review.

> Cool, looks good to me! > > Could you please ping @sahil839 for a review once the tests have been updated? @sahil839 Ready for review.

@sahil839 Ready for another review.

> The Add stream button does not have same height as other buttons in the app. The `Add stream` button height is the same as submit buttons in other modals....

@timabbott Ready for review. The issue is that the `dropdown-menu` has a fixed position ([due to this](https://github.com/zulip/zulip/pull/20447)) even if the modal height is increased by selecting more streams, which pushes...

> @ganpa3 Did the rebase resolve the dropdown issue? No. I am working on incorporating https://github.com/zulip/zulip/pull/25446 changes to this PR and will soon push the changes to this PR.