Ganesh Pawar

Results 41 comments of Ganesh Pawar

> Hm, the disabled pointer in the screen capture above doesn't match what I see in other settings (e.g. deactivate organization without permission, etc.). (Is it the size of the...

> @ganpa3 is this ready for code review? @sahil839 would probably be a good person to take a look next. Yes.

> In the stream creation form, if I type an invalid value which does not matches in typeahead and click on Add the widget is cleared and the button disabled...

> What do you have to do to re-enable the button after getting such an error? It seems problematic for the button to be disabled with no obvious way to...

> What do you have to do to re-enable the button after getting such an error? It seems problematic for the button to be disabled with no obvious way to...

> Noticed one thing, clicking the Owner select field(without making any change) makes the save changes button lose its disabled state, unlike when we click on the Role select field....

> Thanks for the review! > > The role behavior seems like a bug -- it should be possible to just change the role, and save your changes. It _is_...

@sahil839 Thanks for the hint. Updated the PR.

> Sounds good. @ganpa3 I can test when the conflicts have been resolved. Rebased the PR. Ready for review.