ganga icon indicating copy to clipboard operation
ganga copied to clipboard

fix issues with some malfunctioning docker commands (#2309)

Open dg1223 opened this issue 10 months ago • 1 comments

The following Docker commands now work correctly:

d = Docker()
d = Docker('fedora:latest')
d = Docker(image='fedora:latest')
d = Docker(image='fedora:latest', mode='P1')

In addition, added unit tests for each of these commands.

Please note that this fix does not remove the __init__ function from Docker,py as suggested here. Instead, it sets default values for the image and mode parameters in the __init__ function in Docker.py.

dg1223 avatar Mar 30 '24 18:03 dg1223

@dg1223 Thanks for adding the test cases as well.

egede avatar Apr 10 '24 01:04 egede

@dg1223 Thanks for adding the test cases as well.

No problem at all!

dg1223 avatar Apr 12 '24 11:04 dg1223