openmtp icon indicating copy to clipboard operation
openmtp copied to clipboard

App refuses to transfer files with question marks in them

Open tyteen4a03 opened this issue 3 years ago • 5 comments

Versions:

  • Android 11 (May Security Patch) on my Pixel 5
  • OpenMTP Version 3.1.5 (3.1.5) on Legacy MTP mode

If you attempt to transfer a file with a question mark in the filename, the app chokes and never finishes the transfer.

tyteen4a03 avatar May 16 '21 23:05 tyteen4a03

Interesting. I will check this.

ganeshrvel avatar May 21 '21 20:05 ganeshrvel

EDIT : Quotation mark (") generates the same problem as (?)

I just transfered ~1000 songs previously corrected with ABFR to batch remove ? and " chars. Didn't find any other problem. I'll come back with more if any.

Android 11 One UI 3.1 Galaxy Tab S5e - OpenMTP 3.1.10 - MacOS Mojave 10.14.6

Voreball avatar Jun 07 '21 17:06 Voreball

@Voreball I was able to reproduce this issue. But the situation is a tad more complication. I could easily fix this by sanitizing the filenames but the same gets a complicated for directories.

I need more time on this issue as I need to make sure that I dont break anything

ganeshrvel avatar Jun 30 '21 13:06 ganeshrvel

A vote for not just sanitizing filenames, because that can lead to data loss. Properly encapsulating Unicode all the way through your internal file name handling can be a real pain, but it's worth it.

resuna avatar Aug 21 '21 15:08 resuna

Can confirm, also '#' ... and @resuna, parhaps it has more to do with the receiving file system than with unicode?

murb avatar Jul 13 '23 13:07 murb