mem_absa icon indicating copy to clipboard operation
mem_absa copied to clipboard

questions about the procedure of test()

Open jaredwei01 opened this issue 7 years ago • 2 comments

In the method "test" in model.py, it seems that there is a module about training the model using the test data.(from line 236 to 244 ). I wonder why we should use test golden label here and in line 230, is it used as a validation ? I'm new in tensorflow, please pardon me if there were errors in my understanding.

jaredwei01 avatar Mar 16 '17 10:03 jaredwei01

Yes, its a bug. Change that portion to this: loss = self.sess.run([self.loss], feed_dict={ self.input: x, self.time: time, self.target: target, self.context: context}) so that we just seek the loss without doing backprop.

Also there is a bug in data.py. We need to discard input samples from the class label: 'conflict' as suggested by the author.

Send a PR if someone had fixed this successfully.

ganeshjawahar avatar Mar 24 '17 09:03 ganeshjawahar

Hi @ganeshjawahar,

can you elaborate more about bug in data.py ? What should i change? Thank you!

jurukode avatar May 09 '17 07:05 jurukode