HX711 icon indicating copy to clipboard operation
HX711 copied to clipboard

(small) issue with _read internal method

Open hsors opened this issue 4 years ago • 1 comments

Hi gandalf15, thanks much for your code. It's very neat and well documented. Very convenient to dig into. I have detected a small issue in _read() code of your HX711 class. You test 40 times is the chip is ready but if it if not, the error message is not displayed and the code continues because you test if the ready counter is equal to 50 (instead of 40). Again, thanks much for the good work !

hsors avatar Mar 26 '20 17:03 hsors

Hi there, I am sorry for the very late reply but I've been busy. Thanks for pointing this out. I just have to delete the code that is commented. It happens very often that it does not read correctly and we would end up with a lot of error messages. Instead, I just decided to ignore the unsuccessful reads and just continue. I'll deal with this in the next commit.

gandalf15 avatar Jun 24 '20 09:06 gandalf15