gammapy icon indicating copy to clipboard operation
gammapy copied to clipboard

css for sphinx v15

Open stahanna opened this issue 2 years ago • 5 comments

Description

This pull request ...

Dear reviewer

stahanna avatar Feb 23 '24 10:02 stahanna

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.24%. Comparing base (7e8371f) to head (4293df1). Report is 10 commits behind head on main.

:exclamation: Current head 4293df1 differs from pull request most recent head 5675db0. Consider uploading reports for the commit 5675db0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
+ Coverage   75.22%   75.24%   +0.01%     
==========================================
  Files         234      234              
  Lines       34843    34850       +7     
==========================================
+ Hits        26211    26222      +11     
+ Misses       8632     8628       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 23 '24 10:02 codecov[bot]

You can check the result here : https://stahanna.github.io/gammapy-docs-preview/

registerrier avatar Mar 08 '24 13:03 registerrier

My situation with the dark theme: Capture d’écran 2024-03-08 à 14 28 32

cgalelli avatar Mar 08 '24 13:03 cgalelli

Thanks, @cgalelli! I guess this is completely expected, our CSS and images are not suited for a dark theme. It would require much more work to adapt it...

adonath avatar Mar 08 '24 13:03 adonath

Thanks @stahanna

Here are my comments:

  • various drop down menus do not actually drop down
    • https://stahanna.github.io/gammapy-docs-preview/getting-started/index.html#tutorials-overview
    • https://stahanna.github.io/gammapy-docs-preview/user-guide/howto.html
  • on the right hand side it should show what is available on the page, but the font appears to be in white, so it does not show (see screen shot). This is happening on every page image

Astro-Kirsty avatar Mar 11 '24 10:03 Astro-Kirsty

Thanks a lot @stahanna ... It looks nice. I have a simple question. In the API page (https://stahanna.github.io/gammapy-docs-preview/api-reference/index.html), it seems that the dots are not present. Do you see the same with your browser?

bkhelifi avatar Mar 26 '24 16:03 bkhelifi

@bkhelifi I checked the pandas documentation and they miss the ::marker as well in the API section (already since the v 1.5) not sure if I can fix it easily then

stahanna avatar Mar 27 '24 10:03 stahanna

CI fail is unrelated. Merging now.

registerrier avatar Apr 02 '24 07:04 registerrier

@registerrier The CI failure is NOT unrelated: the conda based CI fails precisely due to the changes in environment-dev.yaml in this PR.

maxnoe avatar Apr 02 '24 16:04 maxnoe