gammapy
gammapy copied to clipboard
PIG 23 - Gammapy Release Cycle and Version Numbering
Description
This pull request introduces a PIG on the release scheme and development workflow after v1.0
For now it is a first draft.
Dear reviewer
Codecov Report
Merging #3950 (5d96871) into master (89f67e3) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
- Coverage 94.05% 94.04% -0.02%
==========================================
Files 162 162
Lines 21402 21438 +36
==========================================
+ Hits 20130 20161 +31
- Misses 1272 1277 +5
Impacted Files | Coverage Δ | |
---|---|---|
gammapy/modeling/iminuit.py | 92.52% <0.00%> (-1.87%) |
:arrow_down: |
gammapy/maps/wcs/ndmap.py | 91.12% <0.00%> (-0.44%) |
:arrow_down: |
gammapy/maps/hpx/ndmap.py | 92.45% <0.00%> (-0.41%) |
:arrow_down: |
gammapy/data/obs_table.py | 91.45% <0.00%> (-0.29%) |
:arrow_down: |
gammapy/modeling/models/temporal.py | 99.05% <0.00%> (-0.01%) |
:arrow_down: |
gammapy/maps/wcs/geom.py | 96.49% <0.00%> (ø) |
|
gammapy/estimators/points/lightcurve.py | 100.00% <0.00%> (ø) |
|
gammapy/datasets/map.py | 93.56% <0.00%> (+0.02%) |
:arrow_up: |
gammapy/maps/region/ndmap.py | 93.37% <0.00%> (+0.04%) |
:arrow_up: |
gammapy/maps/core.py | 86.55% <0.00%> (+0.07%) |
:arrow_up: |
... and 6 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
- I suppose that we will have situations where the same bug fix implementation cannot be applied between
1.0.y
and1.x.y
because there can be API changes. So the PRs have to be adjusted accordingly?
Good question. I have left a question in the text, but this might not need to be explained in the PIG. Any idea @adonath ?
- I do not know if we are sufficiently well-planned yet to propose deprecation warnings. Maybe we can try putting it, but not make it necessary by adding in the PIG?
After the co-working week close out meeting we decided to include them.
This is now ready for review. Please comment! @adonath @AtreyeeS @QRemy @bkhelifi @fabiopintore @LauraOlivera @cosimoNigro and all.
Hi My 2 cents. I have read the PIG and can´t see any obvious flaw or case when this should not work, but I have little experience in managing large packages on long time scales. It looks more difficult to handle than before, for the developers, but better for users.
José Luis