enrico icon indicating copy to clipboard operation
enrico copied to clipboard

Name conflict with more than one analysis in same directory

Open zblz opened this issue 10 years ago • 7 comments

When doing two or more analysis (with same source but different [file]/tag) in the same directory, most of the resulting files are differentiated by the tag in the filename, but some are not and therefore conflict between analysis. A few I have found (probably to exhaustive):

  • Spectrum dir
  • TSmap (some files whithin have tag, most don't)
  • Lightcurve_Nbins (for folded lightcurves, the N bins can be repeated for different time periods)
  • Subtract_Model_cmap and Residual_Model_cmap

These file/dir names should be changed to include the tag.

zblz avatar Nov 17 '14 10:11 zblz

I've been playing around with this and can easily fix it, but it will likely be backwards incompatible: the plot scripts will look for a directory named, e.g., TSMap_3yr (where 3yr would be the tag), but if the TSMap was computed with an enrico version before the fix, the directory would be simply named TSMap. @davidsanchez, @cdeil: Do you think it is worth it to implement the fix so that two differently tagged analysis can be run in the same directory, or we juts add a mention in the docs that each analysis should be done in a separate directory?

zblz avatar Nov 17 '14 19:11 zblz

I think so far Enrico users should do one analysis per folder ... I guess this could be made even more clear here by adding an info or warning box.

With this philosophy the tag really woudn't be needed at all, so what is there now (tag, but can't use it to do several analyses by changing the tag) is not super-nice.

@zblz Any PR to improve the current docs or actually make multiple analyses in one folder work are very welcome!

cdeil avatar Nov 18 '14 08:11 cdeil

I agree with Christoph

davidsanchez avatar Nov 18 '14 14:11 davidsanchez

Maybe the tag could be omitted altogether to avoid misunderstanding?

zblz avatar Nov 18 '14 15:11 zblz

:+1: from my side.

@davidsanchez Would you mind if the tag were removed (and maybe filenames generally cleaned up a bit)? E.g. because you have lots of old enrico analyses that you still want to be able to continue processing?

cdeil avatar Nov 18 '14 16:11 cdeil

I think this will not be compatible with previous analysis (not only mine) and I don't see the point also. I use tag to remember the purpose of the analysis

davidsanchez avatar Nov 19 '14 07:11 davidsanchez

Ok, I'll see where in the docs I can add a mention that each analysis must be in their own directory.

zblz avatar Nov 19 '14 07:11 zblz