HexMod icon indicating copy to clipboard operation
HexMod copied to clipboard

Published 20 hours ago • verified publisher icon gamma-delta

Scout's with no media and no enlightenment still succeeds

Open object-Object opened this issue 2 years ago • 5 comments

2023-02-04_21 36 38

object-Object avatar Feb 05 '23 02:02 object-Object

i think this is an issue with all ConstMediaActions. Not sure if it's changed for 0.11 though

SamsTheNerd avatar Nov 11 '23 22:11 SamsTheNerd

Let's test it in the 1.20.1 prereleases.

object-Object avatar Jan 11 '24 03:01 object-Object

Issue still present in Fabric 0.15.10 Hex casting pre-634

Ch1216 avatar Apr 20 '24 21:04 Ch1216

The issue occurs because ConstMediaAction calls execute in Action#operate, which runs before media is withdrawn in side effects.

image

I guess the fix would be to do something similar to SpellAction, where ConstMediaAction adds a side effect to actually do the work of the action?

(edit: seems to work the same on 1.19 and 1.20)

object-Object avatar May 05 '24 23:05 object-Object

okay, I see why it doesn't already work like that - none of the side effects on 1.19 are able to modify the harness state, so they wouldn't be able to push stuff to the stack. In 1.20 we could maybe use AttemptSpell?

object-Object avatar May 06 '24 00:05 object-Object