HexMod icon indicating copy to clipboard operation
HexMod copied to clipboard

Published 20 hours ago • verified publisher icon gamma-delta

[Bug] now the OTHER fisherman's gambit is broken

Open object-Object opened this issue 2 years ago • 2 comments

Fisherman's Gambit is 1-indexed. Fisherman's Gambit II is 0-indexed. image image

object-Object avatar Dec 13 '22 02:12 object-Object

Tempted to call that intended behavior; the reason I is "1-indexed" is because it's counting the number that's popped off as 0...

gamma-delta avatar Dec 24 '22 20:12 gamma-delta

Fair, I guess, but in my opinion it's so unintuitive for two patterns with the same name and the same sort of behaviour to use two different indexing systems. This whole thing with Fisherman's being 0 or 1 indexed changing by the update has tripped me up more times than I can count.

object-Object avatar Dec 24 '22 21:12 object-Object

I've set this as tentatively planned for 0.11.1, because this is the sort of thing that feels like it would be better to change when we're already breaking hexes in a bunch of other ways, than in a patch release.

object-Object avatar Aug 23 '24 01:08 object-Object

duplicate of #447 apparently

object-Object avatar Sep 11 '24 21:09 object-Object