LagMonitor icon indicating copy to clipboard operation
LagMonitor copied to clipboard

Timing configuration removed in bukkit & spigot yml

Open EHCanadian opened this issue 6 years ago • 4 comments

Looks like it has been moved to settings: plugin-profiling: true in bukkit.yml.

https://www.spigotmc.org/wiki/how-to-take-a-timings-report/

function isTimingsEnabled is using Bukkit.getPluginManager().useTimings(); It no longer exists in 1.13+. Googled. Could not find anything on google about this..

You can run /timings on the console, client but it does not stay on during a restart|stop command it seems. Even when set to on the /timing command from the README.md (Configuration) throws the boolean false statement that says

"The server deactivated timing events....."

EHCanadian avatar Nov 18 '18 18:11 EHCanadian

function isTimingsEnabled is using Bukkit.getPluginManager().useTimings(); It no longer exists in 1.13+. Googled. Could not find anything on google about this..

It's still available in 1.13: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/plugin/PluginManager.html#useTimings--

You can run /timings on the console, client but it does not stay on during a restart|stop command it seems. Even when set to on the /timing command from the README.md (Configuration) throws the boolean false statement that says

So after /timings on /timing still doesn't work?

games647 avatar Nov 18 '18 20:11 games647

Correct. /timing throws "The server deactivated timing events....." even after /timings on .. even waited 120 seconds and tried /timing again still same error.

Ok. So it exists in the hub.spigot end.. Not in the https://www.spigotmc.org/wiki/spigot/ or bukkit.yml or spigot.yml

Do you know the old variable name that should have existed in the yml file. Can try manually adding it to see if we can update the README.md

EHCanadian avatar Nov 18 '18 20:11 EHCanadian

Found this...

https://hub.spigotmc.org/stash/users/electronicboy/repos/bukkit/browse/src/main/java/org/bukkit/command/defaults/TimingsCommand.java#39

Regarding the timing function

EHCanadian avatar Nov 18 '18 20:11 EHCanadian

function isTimingsEnabled is using Bukkit.getPluginManager().useTimings(); It no longer exists in 1.13+. Googled. Could not find anything on google about this..

It's still available in 1.13: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/plugin/PluginManager.html#useTimings--

You can run /timings on the console, client but it does not stay on during a restart|stop command it seems. Even when set to on the /timing command from the README.md (Configuration) throws the boolean false statement that says

So after /timings on /timing still doesn't work?

Yes, it doesn't work also spigot 1.12.2

DahunDev avatar Jan 30 '19 03:01 DahunDev