unity-test-runner icon indicating copy to clipboard operation
unity-test-runner copied to clipboard

fix: Action did not work on Windows runners.

Open sokuhatiku opened this issue 1 year ago • 2 comments

Changes

Fix action to work on windows-latest

  • Replaced symlink to simple javascript.
  • Fixed wrong UnityEditor paths.
  • Fixed wrong project path at Standalone tests.
  • Added nographics option to Editor command line variable.

Added tests to verify that action works on windows-latest

  • Specified runs-on bash for replacing script backend process for IL2CPP.

Related Issues

  • #200

Successful Workflow Run Link

  • https://github.com/sokuhatiku/unity-test-runner/actions/runs/7463004561

Notes

  • This PR adds -nographics option to the Unity command line arguments on windows runner. This change affects tests that use graphics features such as RenderTexture for example.
  • To see if tests work correctly with windows-latest, this PR increases number of test patterns in main.yml from 49 to 79.

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [ ] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
  • [x] Readme (updated or not needed)
  • [x] Tests (added, updated or not needed)

sokuhatiku avatar Jan 12 '24 18:01 sokuhatiku

Cat Gif

github-actions[bot] avatar Jan 12 '24 18:01 github-actions[bot]

@sokuhatiku Would you mind rebasing and regenerating the dist files? Should be straight forward.

I think it would be great to merge this one.

webbertakken avatar Mar 15 '24 00:03 webbertakken

@webbertakken I've rebased and regenerated the dist files as requested.

sokuhatiku avatar Mar 21 '24 13:03 sokuhatiku