unity-builder
unity-builder copied to clipboard
Fixed missing BlankProject
Changes
- Removed creation and deletion of BlankProject on Mac runners
Deleting the BlankProject on cleanup creates the following issue when calling the action multiple times in a row:
Couldn't set project path to:
Aborting batchmode due to failure:
Couldn't set project path to:
[Package Manager] Server::Kill -- Server was shutdown
Unclassified error occured while trying to activate license.
Exit code was: 1
Error: There was an error while trying to activate the Unity license.
Error: Build failed with exit code 1
There is no need to create the BlankProject as it already exists in the action.
Successful Workflow Run Link
This only affects self-hosted mac runners. Cannot share a workflow run here unfortunately.
Checklist
- [x] Read the contribution guide and accept the code of conduct
- [x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
- [x] Readme (updated or not needed)
- [x] Tests (added, updated or not needed)
Any blocker to merge @GabLeRoux ?
I'd gladly look at the test runner action if I have some time.
The code that's being removed here doesn't fail by itself.
-
mkdir -p "$ACTIVATE_LICENSE_PATH"
has the-p
flag that makes sure it doesn't fail if the folder already exists. -
rm -r "$ACTIVATE_LICENSE_PATH"
will never fail because the folder is guaranteed to exist.
The change you're proposing doesn't actually fix any error as far as I can see. What am I missing?
Please also note that this way of activation was added because it is needed for the normal activation workflow and can not simply be deleted.
I see a single thumbs up and no other people have reported this same problem. I'm going to have to close this in favour of a different kind of fix if any. Are you still running into a problem with this @homapf?
cc: @GabLeRoux