unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

Feature/licensing server macos

Open simensan opened this issue 2 years ago • 6 comments

Changes

  • Added support for licensing server when building unity project on mac.

I do not have ability to verify that the username/password/serial flow still works. So please sanity check the changes, or even better test it if you have ability to. I had to remove sending in username/password in build.sh, but that shouldn't be required as it is activated already, and we do not do that in the ubuntu version of build.sh.

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
  • [x] Readme (updated or not needed)
  • [x] Tests (added, updated or not needed)

simensan avatar Sep 19 '23 18:09 simensan

Cat Gif

github-actions[bot] avatar Sep 19 '23 18:09 github-actions[bot]

Codecov Report

Merging #573 (d2f8361) into main (a13443a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d2f8361 differs from pull request most recent head 482c00f. Consider uploading reports for the commit 482c00f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   37.02%   37.02%           
=======================================
  Files          77       77           
  Lines        3041     3041           
  Branches      632      632           
=======================================
  Hits         1126     1126           
  Misses       1765     1765           
  Partials      150      150           

codecov-commenter avatar Sep 19 '23 18:09 codecov-commenter

Hi, any chance to merge this in? I have another dependent PR lined up. Thanks!

simensan avatar Oct 18 '23 17:10 simensan

Hey there! Apologies for the extreme delay. We can work on getting this merged but there are a few merge conflicts that need to be resolved before we can merge. If you could resolve them then ping for a review here I can make that happen.

AndrewKahr avatar Nov 12 '23 13:11 AndrewKahr