unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

Fix: builds for Unity versions less than 2019 fail

Open cabauman opened this issue 2 years ago • 2 comments

Changes

Discovered when the gameci/docker repo CI failed in this PR.

Assets/Editor/Editor/UnityBuilderAction/Input/AndroidSettings.cs(14,32): error CS0117: 'PlayerSettings.Android' does not contain a definition for 'useCustomKeystore'

It's complaining about the line added in this unity-builder commit on May 21st.

PlayerSettings.Android.useCustomKeystore = true;

useCustomKeystore was added in Unity 2019 which is why 2018 builds fail.

Might also be worth adding Unity 2018 to the CI version list to prevent regressions.

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Readme (updated or not needed)
  • [x] Tests (added, updated or not needed)

cabauman avatar Oct 15 '22 04:10 cabauman

Cat Gif

github-actions[bot] avatar Oct 15 '22 04:10 github-actions[bot]

Codecov Report

Merging #467 (1ab54fe) into main (f054aaa) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          66       66           
  Lines        2056     2056           
  Branches      353      385   +32     
=======================================
  Hits         1080     1080           
  Misses        972      972           
  Partials        4        4           

codecov-commenter avatar Oct 15 '22 16:10 codecov-commenter