Stackable icon indicating copy to clipboard operation
Stackable copied to clipboard

fix (carousel block): show inner column margins in frontend

Open kaeizen opened this issue 1 year ago • 4 comments

fixes #3173

kaeizen avatar Jul 22 '24 01:07 kaeizen

🤖 Pull request artifacts

file commit
pr3257-stackable-3257-merge.zip ee8900cdc797808cb31b90030b3ba94ee9c6c08b

github-actions[bot] avatar Jul 22 '24 01:07 github-actions[bot]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3257-stackable-3257-merge.zip"}}]}

github-actions[bot] avatar Jul 22 '24 01:07 github-actions[bot]

@mxkae The fix didn't apply on my end. Is there any setting I need to apply to show the fix? 🤔

https://github.com/user-attachments/assets/22f4375a-958e-4831-98f0-0954dc44bcb7

andeng1106 avatar Aug 15 '24 07:08 andeng1106

@andeng1106 our fix is just to remove the ability to change the margins when inside columns since you can achieve the same results with containers

bfintal avatar Aug 15 '24 07:08 bfintal