Stackable icon indicating copy to clipboard operation
Stackable copied to clipboard

fix (button group): flex wrap with full width not working in frontend

Open bfintal opened this issue 1 year ago • 3 comments

fixes #3135

bfintal avatar May 08 '24 05:05 bfintal

🤖 Pull request artifacts

file commit
pr3181-stackable-3181-merge.zip daf52fd0c6a4f23cf08f60b2ac9f9736e90e4971

github-actions[bot] avatar May 08 '24 05:05 github-actions[bot]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3181-stackable-3181-merge.zip"}}]}

github-actions[bot] avatar May 08 '24 05:05 github-actions[bot]

@bfintal Scenario 1 is now fixed. One thing I need to confirm for Scenario 2:

  • Scenario 2 still looks different compared from editor vs. frontend. Is this okay?

https://github.com/gambitph/Stackable/assets/103395655/f07ce552-aa10-4025-9c33-34c259396ffb

andeng1106 avatar May 08 '24 07:05 andeng1106

@andeng1106 please note that this PR addresses all these issues:

  • Full width buttons and flex wrapping now work correctly
  • Button text now doesn't wrap - they look more like what you get in the editor
  • Button group vertical alignment now works correctly on multiple buttons (to try it out, hold shift then press return to add a next line)

bfintal avatar May 18 '24 04:05 bfintal