Stackable icon indicating copy to clipboard operation
Stackable copied to clipboard

fix (map): allow dynamic content in location field

Open prconcepcion opened this issue 1 year ago • 3 comments

fixes #3068

prconcepcion avatar Mar 12 '24 02:03 prconcepcion

🤖 Pull request artifacts

file commit
pr3105-stackable-3105-merge.zip 6fb87ef94677b51429d2b0771d817babcdd8540e

github-actions[bot] avatar Mar 12 '24 02:03 github-actions[bot]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3105-stackable-3105-merge.zip"}}]}

github-actions[bot] avatar Mar 12 '24 02:03 github-actions[bot]

@prconcepcion remaining issues:

  • [ ] When changing the values, it's not automatically fetched by the Map block. I need to refresh page, re-add again to see changes.

https://github.com/gambitph/Stackable/assets/103395655/2c16b675-5ef6-45e8-851e-6f00dd9724ab

  • [ ] If no API key is present and upon fetching dynamic data, it doesn't show correctly on editor

https://github.com/gambitph/Stackable/assets/103395655/9c4d5f01-0549-497e-8b4c-4618f97cce91

  • [ ] No API key - Upon refreshing page, the dynamic data deselects and data becomes a text content

https://github.com/gambitph/Stackable/assets/103395655/b42ece1c-4862-4bb4-b8e4-602e484582e1

cc: @bfintal

andeng1106 avatar Mar 22 '24 06:03 andeng1106