Stackable icon indicating copy to clipboard operation
Stackable copied to clipboard

The strings in the example.js files are not translatable

Open DAnn2012 opened this issue 4 years ago • 3 comments

Hello @bfintal

I noticed that in the block preview in the editor the strings are shown in English for the other languages as well. Maybe because the strings in the example.js files of the blocks are in an untranslatable format?

I am attaching some examples to better describe the problem.

Thanks.

Schermata 2021-12-04 alle 10 39 38

https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/heading/example.js#L3

Schermata 2021-12-04 alle 10 40 34

https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/blockquote/example.js#L10

Schermata 2021-12-04 alle 10 41 00

https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/call-to-action/example.js#L6 https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/call-to-action/example.js#L10 https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/call-to-action/example.js#L17

Schermata 2021-12-04 alle 10 41 26

https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/expand/example.js#L6 https://github.com/gambitph/Stackable/blob/bccfbffd9011c136df6417c0d8997e378f968cc7/src/block/expand/example.js#L10

DAnn2012 avatar Dec 08 '21 09:12 DAnn2012

Hello @bfintal

as soon as you can, could you take a look at this problem?

Thanks.

DAnn2012 avatar Jun 24 '22 13:06 DAnn2012

Hello @bfintal

Excuse me if I insist once again. But I ask you please to look into this problem, I think it is important to show the translation also for the Stackable block examples for consistency with the Gutenberg block examples (which are translated).

Thank you.

Gutenberg block examples:

gutenberg-is-translated

Stackable block examples:

stackable-is-not-translated

DAnn2012 avatar Jul 31 '22 07:07 DAnn2012

Hello @bfintal @prconcepcion @vmc08

I apologize for the trouble and insistence.

Please, has one of you already taken a look at the problem?

Thanks.

DAnn2012 avatar Aug 23 '22 07:08 DAnn2012