Inactive greyed icons incorrectly displayed on Linux

[AlexisDrogoul]

Steps to reproduce

1. Run any model

2. Observe the "step" icon (second from the left)

3. When the simulation is run, it becomes gray and blurry (as if its size is doubled).

It happens with other icons as well (back/forward icons in the editor when no text has been entered, "Simulation Perspective Icon" when no experiment is running, etc...

It seems to be related to the fact that I am running on an HiDPI screen. Can someone test this on "normal" screens ?

System and version

Gama git version, Ubuntu 20.04

[lesquoyb]

Tried on my laptop: no problem as long as I keep a 100% scaling, if I change to any other value I get the same problem

[lesquoyb]

I tried the new bug fix, nothing changed on my computer. In case it can help: I noticed that the icon size is smaller with a scaling of 200%: than with a scaling of 125%: which is the opposite of what I would have expected

[AlexisDrogoul]

The last commit effectively does not solve the issues in the global toolbar, which is described in the plugin.xml (see the screenshot) and not programmatically -- so all the changes are managed by SWT directly.

This issue is maybe related to this : https://bugs.eclipse.org/bugs/show_bug.cgi?id=568407, which is however marked as solved. Does changing GTK version affect the outcome ?

The positive point, however, is that the fix seems to solve the editors' toolbars icons, which are managed programmatically in GAMA: before the fix, the "greyed out/disabled" icons where computed automatically by SWT (like in the global toolbar), now they are computed in GamaIcons, indicating that SWT does not take into account the "disabled" icon in the plugin.xml and that the problem is in this "disablement" computation on Linux. This is confirmed by https://bugs.eclipse.org/bugs/show_bug.cgi?id=575492 that pinpoints exactly the same issue (w/o a fix or a workaround, however).

[AlexisDrogoul]

Should be tested with the new version of Eclipse (either 2022-06 - https://www.eclipse.org/downloads/packages/release/2022-06/r/eclipse-ide-java-and-dsl-developers - or the upcoming 2022-09 - https://download.eclipse.org/eclipse/downloads/drops4/S-4.25M3-202208171800/ -)

[RoiArthurB]

@AlexisDrogoul I'm building some GAMA with Eclipse 2022-06, I let you try to see if it fix the issue and doesn't create any new ones : https://github.com/RoiArthurB/GAMA-182-test-builder/actions/runs/2903093404

PS: On my Linux I never saw this issue and can't reproduce it :/

[AlexisDrogoul]

Problem has been fixed on the SWT side (https://github.com/eclipse-platform/eclipse.platform.swt/pull/327), but it won't be out for 4.25 (Eclipse 2022-09). Should we wait til December ?

[lesquoyb]

I don't think waiting to try with the next release would be an issue considering that there will still be some work going on until at least October (and the release could be out before December like it was the case for the September release)

[AlexisDrogoul]

We should build GAMA with 2022-12 now that #3553 is fixed -- and this would remove this issue as well.

[RoiArthurB]

Fixed with the issue #3553 and the merge of #3544 :)