training-material
training-material copied to clipboard
galaxyproject
Updated Deep Learning (DL) workflows to use the most recent DL tools version
It looks like you're using the tutorial mode tool linking in the tutorials, since it looks like you're changing at least one tool id, can you please check the associated tutorials to make sure they're using the correct IDs as well?
This was the one I noticed, there may be more. "toolshed.g2.bx.psu.edu/repos/bgruening/keras_model_config/keras_model_config/0.5.0",
@hexylena Good catch! I updated the tool versions in tutorials and pushed the change.
I tried to run these workflows on the EU but the jobs have not started so far. I guess they are in queue waiting for GPUs. I will try on Org
@anuprulez I tried uploading the files for RNN tutorial. I got an error uploading it, but re-tried and it succeeded. I then ran the workflow and got similar results as in the tutorial. So, I think we are good for FNN and RNN workflows/tutorials.
As for the CNN tutorial, I guess removing the 'padding="same"' maybe the culprit. I am investigating that problem right now. Will let you know when I resolve it.
@anuprulez I tried uploading the files for RNN tutorial. I got an error uploading it, but re-tried and it succeeded. I then ran the workflow and got similar results as in the tutorial. So, I think we are good for FNN and RNN workflows/tutorials.
As for the CNN tutorial, I guess removing the 'padding="same"' maybe the culprit. I am investigating that problem right now. Will let you know when I resolve it.
Thanks @anuprulez, I fixed a few errors in options and now all the lint tests pass. Can this be reviewed/approved now?
@kxk302 Is the issue related to padding="same" for CNN tutorial fixed by this PR: https://github.com/bgruening/galaxytools/pull/1201? Unfortunately, a few tests are still failing in this PR. I think this was the only problem left to be fixed (CNN workflow/tutorial), the other two workflows worked fine.
@kxk302 Is the issue related to
padding="same"for CNN tutorial fixed by this PR: bgruening/galaxytools#1201? Unfortunately, a few tests are still failing in this PR. I think this was the only problem left to be fixed (CNN workflow/tutorial), the other two workflows worked fine.
@anuprulez yes, it's a fix for padding='same' issue. I see all checks as being green. Can you please post a link to the failing test? Thanks!
I think once these test passes (from the PR: https://github.com/bgruening/galaxytools/pull/1201) and updated tools are installed, the PR (https://github.com/galaxyproject/training-material/pull/3292) will automatically start working. I will verify this once the new versions of tools (from the PR: https://github.com/bgruening/galaxytools/pull/1201) are installed. Thanks for working on this @kxk302
