training-material icon indicating copy to clipboard operation
training-material copied to clipboard

[WIP] GTN_msPurity

Open jsaintvanne opened this issue 5 years ago • 5 comments

Hi everybody,

I'm actually making a new GTN on msPurity processing from mzML files to some annotations. This PR has been made for each question or any review for things that I'm doing bad...!

Don't hesitate to react ! I'm developping it and each questions or review can help me!

Thanks

@lecorguille @yguitton @tomnl

jsaintvanne avatar Nov 25 '19 14:11 jsaintvanne

@jsaintvanne @lecorguille @yguitton @Tomnl I am just going through old PRs, came across this 4 year old one. Are you still planning on finishing this one up? If not I will just close it for now (but you are very welcome to open another PR if/when you pick this back up :))

shiltemann avatar Nov 08 '23 10:11 shiltemann

Hi,

We just talked about it yesterday ! Funny thing !

We will rework this GTN during November but we will probably open a new PR so you can close this one I think

jsaintvanne avatar Nov 08 '23 11:11 jsaintvanne

Indeed, true story! We have a working session planned the last week of November. As mentioned by @jsaintvanne since continuing from the same PR may be tricky a little due to it being "paused" for a long time, what I had in mind was taking the current "state" of this PR's tutorial folder and using it as the "first commit" of a new PR, with a link to this one as a comment. Would it be ok to wait for the new PR to be initialised before closing this one? I was planning to initiate the new PR next week in preparation for the working session.

melpetera avatar Nov 08 '23 13:11 melpetera

@melpetera that sounds like a good plan, and absotely its ok to leave it open, just wanted your opinion on it. Let me know if you need any help!

shiltemann avatar Jan 16 '24 01:01 shiltemann

Hi @melpetera @jsaintvanne - let me know if you need any help with this as well

Tomnl avatar Jan 16 '24 08:01 Tomnl