tools-iuc icon indicating copy to clipboard operation
tools-iuc copied to clipboard

Add converter for Kraken to BIOM.

Open davebx opened this issue 8 years ago • 11 comments

Concerns: For the tests to work, the JSON output is prettified. This results in somewhat larger output files.

davebx avatar Dec 16 '15 20:12 davebx

Ping @jxtx due to expressed interest.

davebx avatar Dec 16 '15 20:12 davebx

@davebx I feel not confident to review the converter but the wrappers looks great! So :+1 from me.

bgruening avatar Dec 23 '15 09:12 bgruening

Suggest:

  • add shebang to top of .py files.
  • add __version__ string constant and --version argument
  • Move the converter code to a separate package repository, where installing it will chmod +x the .py using the xml tags. Should also be able to require eg a python package. Now, script can be called by name directly, without specifying interpreter
  • Add options to allow overriding column selections, so that any 'tabular' file can be used as input (tabular to biom converter), defaults can be set to kraken columns. can also hide under advance options (your choice)

blankenberg avatar Jan 26 '16 15:01 blankenberg

That being said, i am +1 on merging this, if additional time is not available for changes.

blankenberg avatar Jan 26 '16 15:01 blankenberg

@davebx your call! Thanks Dan!

bgruening avatar Jan 26 '16 16:01 bgruening

ping @davebx

bgruening avatar Feb 27 '16 07:02 bgruening

made a pr against @davebx https://github.com/davebx/tools-iuc/pull/4

blankenberg avatar Apr 01 '16 21:04 blankenberg

One important issue is that we should be using the taxonomy found in the kraken database directories, not the separately maintained ncbi taxonomy.

blankenberg avatar Apr 01 '16 21:04 blankenberg

I wasn't sure this should be applied to the master branch. Then I remembered that this is tools-iuc, not galaxy.

davebx avatar Apr 05 '16 17:04 davebx

@davebx Can you fix the 6 flake8 errors in https://travis-ci.org/galaxyproject/tools-iuc/jobs/147195352#L443 ?

nsoranzo avatar Oct 06 '16 16:10 nsoranzo

@davebx oof, this one is ancient, still relevant you think? We might be able to use this kraken-biom bioconda package to perform this task?

shiltemann avatar Apr 05 '22 09:04 shiltemann

Closing this in favor of https://github.com/galaxyproject/tools-iuc/pull/4763

bernt-matthias avatar Sep 08 '22 06:09 bernt-matthias