tools-iuc icon indicating copy to clipboard operation
tools-iuc copied to clipboard

sansa: fix tests

Open bernt-matthias opened this issue 2 years ago • 4 comments

size of bcf output changed when the container was updated to quay.io/biocontainers/sansa:0.0.8--h4a2b439_2

so I added delta

FOR CONTRIBUTOR:

  • [x] - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • [x] - License permits unrestricted use (educational + commercial)
  • [ ] - This PR adds a new tool or tool collection
  • [x] - This PR updates an existing tool or tool collection
  • [ ] - This PR does something else (explain below)

bernt-matthias avatar Jul 20 '22 14:07 bernt-matthias

Maybe we could delete the internationalgenome.org URL in this line, because it does still not work and the linter fails because of that. (Is there a way to make to get this nice line preview for lines that have not been changed?)

mira-miracoli avatar Jul 26 '22 09:07 mira-miracoli

Maybe we could delete the internationalgenome.org URL in this line, because it does still not work and the linter fails because of that.

The link seems correct and should stay .. there are more PRs with similar problems .. I guess there is something wrong in the Galaxy/planemo source.

(Is there a way to make to get this nice line preview for lines that have not been changed?)

Not sure what you mean :(

bernt-matthias avatar Jul 27 '22 08:07 bernt-matthias

Maybe we could delete the internationalgenome.org URL in this line, because it does still not work and the linter fails because of that.

The link seems correct and should stay .. there are more PRs with similar problems .. I guess there is something wrong in the Galaxy/planemo source.

Sorry I included the wrong link; the link that causes trouble in Line 286 is still not working for me: https://www.internationalgenome.org/phase-3-structural-variant-dataset

mira-miracoli avatar Jul 28 '22 10:07 mira-miracoli

I reported the URL problem upstream. For my reference: [EBI #604657]

bernt-matthias avatar Aug 05 '22 08:08 bernt-matthias