planemo icon indicating copy to clipboard operation
planemo copied to clipboard

Validate with jsonschema

Open mvdbeek opened this issue 1 year ago • 1 comments

also

  • fixes the wrong and extremely verbose input connection check (we used to print every step dict!)
  • fixes gxformat2 linting if gxformat2 steps are lists and not dicts
  • make unknown job inputs an error (cause you may think you're testing something that you're not)
  • allow elements in top level collection tests in addition to element_tests (i've marked element_tests as deprecated in the schema)

The schema disallows the - that: has_text style assertions. They continue to work in tests but results in linting errrors, I hope that's ok. I've included the schema for now in planemo, but eventually we should either include it in galaxy-tool-util (as soon as pydantic 2 can be supported) or just publish the schema to https://www.schemastore.org/json/. The process seems easy enough, but we may need to come up with a more unique test file name (*.gxwf-test.yml) ?

mvdbeek avatar Dec 08 '23 17:12 mvdbeek

Can you document some where how planemo/schema/test_file_schema.json is generated? Is that present and I missed it?

jmchilton avatar Dec 08 '23 17:12 jmchilton