galaxy
galaxy copied to clipboard
Include version in data_manager_list API and show it in DataManager vue component.
#7326
@scrathat thanks! Can we group/merge the same tool IDs into one entry as proposed by @Slugger70?
Should this target 19.01?
@scrathat thanks! Can we group/merge the same tool IDs into one entry as proposed by @Slugger70?
Different data manager versions are merged into one entry now.
However, for some instances there seems to be a difference between the version info saved in a data manager instance (backend) and the version at the end of a constructed tool url with that same data manager id, e.g. web.url_for(controller='root', tool_id=data_manager.tool.id). Is this normal?
This PR seems to be showing the version from the data_manager_conf.xml i.e. from <data_manager tool_file="data_manager/bowtie_index_builder.xml" id="bowtie_index_builder" version="0.0.1"> instead of the actual version of the tool xml e.g.<tool id="bowtie_index_builder_data_manager" name="Bowtie index" tool_type="manage_data" version="1.2.0"> from bowtie_index_builder.xml

I've pushed this to 19.09 due to outstanding comments
@scrathat you had some questions to @martenson wasn't it?
@martenson i added a commit showing both the tool and the data manager version. As needed i can remove one or the other depending on which version is more relevant.

I have installed two revisions of data_manager_bowtie_index_builder that have the following versions:

But I only see the older version in the UI:

I installed multiple revisions of data_manager_bowtie_index_builder and trans.app.data_managers.data_managers.values() only returns
"toolVersion": "0.0.2" and data manager "version": "0.0.1" and no other revisions.
Works fine with multiple revisions of data_manager_build_kraken_database.
@martenson do you have an idea here? Is that a TS bug?