galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Include version in data_manager_list API and show it in DataManager vue component.

Open scrathat opened this issue 6 years ago • 10 comments

#7326

scrathat avatar Feb 07 '19 23:02 scrathat

@scrathat thanks! Can we group/merge the same tool IDs into one entry as proposed by @Slugger70?

bgruening avatar Feb 08 '19 07:02 bgruening

Should this target 19.01?

bgruening avatar Feb 08 '19 07:02 bgruening

@scrathat thanks! Can we group/merge the same tool IDs into one entry as proposed by @Slugger70?

Different data manager versions are merged into one entry now.

However, for some instances there seems to be a difference between the version info saved in a data manager instance (backend) and the version at the end of a constructed tool url with that same data manager id, e.g. web.url_for(controller='root', tool_id=data_manager.tool.id). Is this normal?

scrathat avatar Feb 08 '19 20:02 scrathat

This PR seems to be showing the version from the data_manager_conf.xml i.e. from <data_manager tool_file="data_manager/bowtie_index_builder.xml" id="bowtie_index_builder" version="0.0.1"> instead of the actual version of the tool xml e.g.<tool id="bowtie_index_builder_data_manager" name="Bowtie index" tool_type="manage_data" version="1.2.0"> from bowtie_index_builder.xml

screenshot 2019-02-15 13 57 36

martenson avatar Feb 15 '19 18:02 martenson

I've pushed this to 19.09 due to outstanding comments

martenson avatar Apr 09 '19 14:04 martenson

@scrathat you had some questions to @martenson wasn't it?

bgruening avatar Apr 09 '19 14:04 bgruening

@martenson i added a commit showing both the tool and the data manager version. As needed i can remove one or the other depending on which version is more relevant.

dm version

scrathat avatar Apr 10 '19 16:04 scrathat

I have installed two revisions of data_manager_bowtie_index_builder that have the following versions: Galaxy___Installed_tool_shed_repositories Galaxy___Installed_tool_shed_repositories

But I only see the older version in the UI: Galaxy

martenson avatar Apr 25 '19 15:04 martenson

I installed multiple revisions of data_manager_bowtie_index_builder and trans.app.data_managers.data_managers.values() only returns "toolVersion": "0.0.2" and data manager "version": "0.0.1" and no other revisions.

Works fine with multiple revisions of data_manager_build_kraken_database.

scrathat avatar Apr 25 '19 16:04 scrathat

@martenson do you have an idea here? Is that a TS bug?

bgruening avatar May 03 '19 13:05 bgruening