galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

changed default location of integrated_tool_panel.xml

Open bernt-matthias opened this issue 7 years ago • 3 comments

I guess it should be in config/ instead of the Galaxy root

bernt-matthias avatar Jun 20 '18 13:06 bernt-matthias

Unit test failures appear to be legitimate, marking as WIP for that reason. @natefoo / @mvdbeek are you okay with moving this? I mean we put mutable stuff in both Galaxy root and config currently - I'm not sure I find a compelling reason to prefer one over the other.

If there is a consensus around making this change though I can fix the unit tests and get this merged.

jmchilton avatar Dec 12 '18 15:12 jmchilton

Sure, seems fine to me. Should we recover integrated_tool_panel.xml from the root dir if it exists there but not in config/ ?

mvdbeek avatar Dec 12 '18 16:12 mvdbeek

I wasn't even aware that it wasn't in config/. I think somewhere in database/ (say database/config/?) actually makes more sense (I call this the "mutable" config/data dir in the Ansible stuff), because ideally config/ is only for stuff an admin writes. The other Galaxy-written configs should also go wherever integrated_tool_panel.xml goes, but those probably aren't something we should change except for new installs.

natefoo avatar Feb 13 '19 23:02 natefoo

This was moved to managed_config_dir long ago.

nsoranzo avatar Sep 17 '22 07:09 nsoranzo