galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Install visualizations directly to static path, avoid duplication

Open guerler opened this issue 9 months ago • 2 comments

Requires #20303. This PR changes the installation target for visualizations from config/visualizations to the static path directly. It also removes the unused html visualization type and degrades the Mako mechanism by disabling the registration of new Mako-based visualizations. The only remaining Mako template is moved to the default template directory and will be removed once the last four Mako-based visualizations are migrated to npm.

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [x] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

guerler avatar May 29 '25 18:05 guerler

Failing tests are unrelated.

guerler avatar Jun 14 '25 13:06 guerler

Thank you for the review @davelopez. I would like to merge this so I can switch between branches without having to reinstall visualizations. I am confident that the mako handling is solid, but if anyone has comments or notices something I can make adjustments. Thank you.

guerler avatar Jun 17 '25 23:06 guerler

Fair enough! I'll merge it now. Thanks!

davelopez avatar Jun 18 '25 07:06 davelopez