galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Data manager writes to 1st (often wrong) loc file

Open bernt-matthias opened this issue 6 months ago • 0 comments

Describe the bug

Data managers apparently write to the first loc file listed in config/shed_tool_data_table_conf.xml. In my config I find

grep busco_database ../config/shed_tool_data_table_conf.xml

    <table name="busco_database" comment_char="#">
        <file path="/gpfs1/data/galaxy_server/galaxy/tool-data/toolshed.g2.bx.psu.edu/repos/iuc/rnaquast/f9f2ad782d8f/busco_database.loc"/>
...
        <file path="/gpfs1/data/galaxy_server/galaxy/tool-data/toolshed.g2.bx.psu.edu/repos/iuc/data_manager_fetch_busco/8ef19ca5d289/busco_database.loc"/>
...

running data_manager_fetch_busco in version 8ef19ca5d289 resulted in a new entry in the rnaquast loc file.

I would also suggest that the behavior implemented in https://github.com/galaxyproject/galaxy/pull/16247 should be changed (maybe it;s even the cause of this bug). It should be reproducible which DM created which entry in which loc file. Otherwise the whole versioning of the data tables has little use. Maybe instead write to the unversioned loc file in the root of the tool-data folder?

Galaxy Version and/or server at which you observed the bug Galaxy Version: 24.1

To Reproduce

Guess it would be sufficient to install two data tables where the one of the datamanger is the 2nd?

Expected behavior

If a DM is run the entry should be added to the loc file of the used DM version.

Additional context

  • This is similar to one of the issues mentioned in https://github.com/galaxyproject/galaxy/issues/17836

bernt-matthias avatar May 05 '25 13:05 bernt-matthias