galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Refactor Object Store Selection Modals UI

Open itisAliRH opened this issue 1 year ago • 3 comments

This pull request introduces a redesign of the Object Store Selection modals for User Preferred, Current History, Tool form and Workflow run form, aiming to enhance user experience through a consistent and modernised interface.

Required: #19521

https://github.com/user-attachments/assets/e85fca15-8c1b-4683-83bd-eb53fb2a28f7

Before After
image image
image image
image image
image image

Key Changes:

  • Enhanced Selection Interface using the SourceOptionCard
  • Update types and improve the logic
  • Use a consistent object store selection for every use case

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.

  • [x] This is a refactoring of components with existing test coverage.

  • [x] Instructions for manual testing are as follows: a1. Go to User Preferences a2. Click on Preferred Storage Location

    b1. Go to the tool run form b2. Select the storage icon at the top of the form toolbar

    c1. Go to the workflow run form c2. Click on the storage icon at the top of the page

    d1. In the current history panel, click on the storage icon on top

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

itisAliRH avatar Feb 25 '25 15:02 itisAliRH

Seems related to the work in https://github.com/galaxyproject/galaxy/pull/19695?

ahmedhamidawan avatar May 06 '25 16:05 ahmedhamidawan

Seems related to the work in #19695?

@ahmedhamidawan Some part of Laila's PR is included in this PR.

itisAliRH avatar May 16 '25 13:05 itisAliRH

This one needs a rebase

davelopez avatar Jun 16 '25 07:06 davelopez