galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Add tags to output datasets from tool form

Open PlushZ opened this issue 1 year ago • 4 comments

This PR introduces a feature to allow users to add tags to output datasets via the ToolForm, which are then applied to the datasets in the user’s history.

Issues to be solved with this PR: https://github.com/galaxyproject/galaxy/issues/8710, https://github.com/galaxyproject/galaxy/issues/13885

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

PlushZ avatar Dec 01 '24 18:12 PlushZ

@itisAliRH Can you have a look?

PlushZ avatar Dec 04 '24 16:12 PlushZ

@PlushZ thank you for your work on this. As we discussed, I made the changes, which look good.

itisAliRH avatar Dec 06 '24 14:12 itisAliRH

Moving the milestone to 25.1, if it is ready before the freeze (scheduled today) this can still make it.

mvdbeek avatar May 09 '25 07:05 mvdbeek

Can you please add tests for tagging the outputs of a regular tool and one for tagging the outputs of a map over job ?

I added unit tests for tagging, not sure if it's correct place for these tests

PlushZ avatar Jun 06 '25 13:06 PlushZ

Can you please add tests for tagging the outputs of a regular tool and one for tagging the outputs of a map over job ?

Can you please add those tests as API tests ? The unit tests don't give me any confidence this actually works due to the amount of mocking and unrealistic commit patterns.

mvdbeek avatar Aug 27 '25 08:08 mvdbeek

@mvdbeek Hi, can you please review when you have time?

PlushZ avatar Sep 23 '25 06:09 PlushZ