galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Make Workflow Invocations for Public Workflows shareable

Open ahmedhamidawan opened this issue 1 year ago • 5 comments

As discussed in https://galaxy.slack.com/archives/C02HJDML6/p1723055111792019, it would be useful if a workflow is shared/published, its invocations being shareable as well would be a useful enhancement.

As of now, since the invocations are not published, we get this at the top of a workflow report, as shared by @abueg : image

ahmedhamidawan avatar Aug 13 '24 15:08 ahmedhamidawan

In the meantime making an invocation's history shared might also be used to allow user access to the invocation (as a quick proxy ... it might still be worth sharing or publishing invocations).

mvdbeek avatar Aug 14 '24 15:08 mvdbeek

I'm gonna to the backend for the history access checks ... it is already there and we just need to flip the security checks from owned to accessible.

mvdbeek avatar Aug 15 '24 08:08 mvdbeek

If you share a history that contains an invocation the invocation also becomes accessible now. What is missing is some hint that you might want to share the history if you make a page accessible that references a history or an invocation.

mvdbeek avatar Aug 23 '24 13:08 mvdbeek

I have shared a history (made it published and even individually shared with the other user) but I still get this:

image

when I run an invocation on this history and get to the invocation route from the other user. Is that still expected?

ahmedhamidawan avatar Aug 28 '24 16:08 ahmedhamidawan

Thanks for checking, my test didn't actually use a user that wouldn't have access to the invocation 🤣. Should be fixed in https://github.com/galaxyproject/galaxy/pull/18746

mvdbeek avatar Aug 28 '24 17:08 mvdbeek