galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Changing current history with a populated uploader prevents users from beginning upload

Open ahmedhamidawan opened this issue 1 year ago • 3 comments

Galaxy Version and/or server at which you observed the bug Galaxy Version: 24.1.2.dev0 (usegalaxy.org)

To Reproduce Steps to reproduce the behavior:

  1. Open the Uploader
  2. Add a file to upload (local file or paste)
  3. Do not start upload yet, and exit the modal
  4. Change your current history
  5. Open Uploader again
  6. Click Start but nothing happens

Expected behavior Clicking Start should start the upload into this changed current history

Screencast

https://github.com/user-attachments/assets/2bac4031-8625-4c3f-92b0-ed6eebbecd7c

ahmedhamidawan avatar Aug 07 '24 17:08 ahmedhamidawan

Just to make sure I got this right. If we have files in the upload that have not yet been sent to the current history and we change the current history:

  • Option 1: the upload queue stops and the remaining files to be uploaded will now target the "new" current history.
  • Option 2: we reset the current upload queue and start fresh for the new current history.
  • Option 3: something else I didn't get...

What option did we decide on for the fix?

davelopez avatar Aug 14 '24 09:08 davelopez

Uploads that are defined at the time of clicking the start button go to the current history.

mvdbeek avatar Aug 14 '24 09:08 mvdbeek

Got it now thanks! :+1:

davelopez avatar Aug 14 '24 10:08 davelopez

This should be fixed by https://github.com/galaxyproject/galaxy/pull/18703

davelopez avatar Sep 17 '24 09:09 davelopez