galaxy
galaxy copied to clipboard
galaxyproject
History deletion wording inconsistency
Describe the bug
The history menu entry Delete this history has a tooltip Permanently delete this history
- Permanently should be removed from the tooltip (because permanence is only optional)
- We should use only one of permanently delete or purge throughout the UI (we use the former in the confirmation dialog and the later in the history list)
Galaxy Version and/or server at which you observed the bug Galaxy Version: 24.1
Permanently should be removed from the tooltip (because permanence is only optional)
I have a change here in https://github.com/galaxyproject/galaxy/pull/18265 (in this commit) that deals with this change.
We should use only one of permanently delete or purge throughout the UI (we use the former in the confirmation dialog and the later in the history list)
Yes, we can pick either Purge or Permanently delete. Purge might make more sense as it appears in tooltips and text next to the purge icon in various places.
Yes, we can pick either Purge or Permanently delete. Purge might make more sense as it appears in tooltips and text next to the purge icon in various places.
I'm fine with either but as a non-native English speaker, I thought "purge" could have negative connotations. The definitions usually say: to remove something bad or wrong while Permanently delete makes it more clear to me what is going to happen and makes me think that there is a difference between "delete" and "permanently delete" which is something people usually are confused when they "delete" something but it is still taking space...
+1
Not sure how, but maybe we could also express that "purge"/"permanently delete" history actually only means that the data associated with the history is removed from disk. But this would probably just increase confusion.
Discussed in dev meeting, seems like preference is to standardize on 'permanently delete', purged is an implementation detail that users odn' tnee dto see.
This has been mostly fixed in https://github.com/galaxyproject/galaxy/pull/18265 (); as far as history details sections and actions go. A few other places still say "Purged" like:
but there is a concern about not enough space to fit "Permanently Deleted" in these cases
One idea, in that particular case, we could keep Purged, the tooltip will explain that it is permanently deleted.
Another idea is to remove the text and increase the icon a bit to make the tooltip target bigger. But I know there are also concerns about showing only icons without text.