galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

[24.0] Check dataset state when attempting to acces dataset contents

Open mvdbeek opened this issue 1 year ago • 1 comments

Fixes a bunch of issues that are regularly logged in sentry.

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek avatar May 23 '24 16:05 mvdbeek

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/galaxy/webapps/galaxy/services/datasets.py

Function Unhandled Issue
show AttributeError: 'NoneType' object has no attribute 'get_filters' /api/datas...
Event Count: 16
show ValueError: invalid literal for int() with base 10: '2.60999' /api/datasets...
Event Count: 8
show ValueError: invalid literal for int() with base 10: '19.0941' /api/datasets...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Amazing honestly! Thanks so much. I feel like this is going to fix a lot of odd little issues I experience when playing with non-tradiational datasets.

jmchilton avatar May 24 '24 13:05 jmchilton

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly /api/datasets/{dataset_id} View Issue

Did you find this useful? React with a 👍 or 👎