galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

[24.1] Tighten axt sniffer

Open martenson opened this issue 1 year ago • 2 comments

e.g. it would incorrectly sniff chain as axt since the comment line starts with "##matrix=axtChain"

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [x] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

martenson avatar May 22 '24 22:05 martenson

@bernt-matthias thanks for the suggestion! I added the test in https://github.com/galaxyproject/galaxy/pull/18204/commits/9ed4eda4b09a8f9fc626bb1ddcaa41ebf3885beb

martenson avatar May 23 '24 18:05 martenson

The failed integration test is relevant.

nsoranzo avatar May 23 '24 23:05 nsoranzo