galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

[24.0] Fix activity bar touch events on iOS devices

Open mvdbeek opened this issue 1 year ago • 1 comments

I'm not sure what the issue is here, the minimal fix is this:

diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

but I think we can probably just rely on events happening on referenceRef.

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek avatar May 08 '24 17:05 mvdbeek

This also happens on an Ipad, and the fix works there as well.

mvdbeek avatar May 09 '24 10:05 mvdbeek