galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Batch operation loading stuck in History panel when adding or removing tags

Open itisAliRH opened this issue 10 months ago • 4 comments

Batch operation loading stuck in History panel:

https://github.com/galaxyproject/galaxy/assets/8046843/f461195f-5c62-4cdb-ab8e-e9b78f6ca4a4

Galaxy Version and/or server at which you observed the bug Galaxy Version: (check <galaxy_url>/api/version if you don't know) Commit: (run git rev-parse HEAD if you run this Galaxy server)

Browser and Operating System Operating System: Windows, Linux, macOS Browser: Firefox, Chrome, Chrome-based, Safari

To Reproduce Steps to reproduce the behavior:

  1. Go to Current History
  2. Select few datasets
  3. Run an operation with selected items (like adding a tag)
  4. See the loading stuck in the datasets list until refreshing the page

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

itisAliRH avatar Apr 25 '24 13:04 itisAliRH

This might be a regression, the factor that makes the Processing operation look like is spinning forever is that there is no update_time change triggered in the current history for some reason.

Does it happen to all operations or just with tags?

davelopez avatar Apr 25 '24 14:04 davelopez

@davelopez It only happens on the Add tags and Remove tags operations because changing tags does not change the history update_time (for all histories). I think we should do nothing after these operations like Build dataset pair operation etc.

itisAliRH avatar Apr 29 '24 09:04 itisAliRH

History pulling is not getting the tag updates until searching or opening a collection.

itisAliRH avatar Apr 29 '24 09:04 itisAliRH

History pulling is not getting the tag updates until searching or opening a collection.

That is because of the same reason, if the history update_time doesn't change after the operation, the history watcher doesn't know it needs to get new updates. I'll investigate why it is not getting triggered now.

davelopez avatar Apr 29 '24 09:04 davelopez

Should be fixed in https://github.com/galaxyproject/galaxy/pull/18068

davelopez avatar May 03 '24 09:05 davelopez