galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Self-reporting error component

Open hujambo-dunia opened this issue 11 months ago • 1 comments

**WORK-IN-PROGRESS, not yet "code complete", at which point should address #17560 **

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

hujambo-dunia avatar Mar 12 '24 15:03 hujambo-dunia

I think this is trying to do too much at once. I think we should build up the framework for dispatching on multiple different kinds of report_types in a branch that is just focused on that and built on top of https://github.com/galaxyproject/galaxy/pull/17953 so we have test cases to ensure everything works.

I would also then separate the refactoring of the Vue components into a separate PR from adding new functionality. For instance one PR where we add your client/src/components/Common/UserReportingError.vue component and none of the functionality is changed and then a separate PR where you use the now test API we integrate separately and use your component in a new scope with a new report type.

jmchilton avatar Apr 10 '24 15:04 jmchilton