galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

tool linter: check for leaf nodes with unstripped text content

Open bernt-matthias opened this issue 1 year ago • 2 comments

another one from the microGalaxy hackaton. bio.tools often contain newlines which are removed by our parser, but it would be better if they would not be there at all (I think).

Created problems for instance in the galaxy_tool_metadata_extractor.

Also removes one test (test_xml_comments_are_ignored) which made no sense (to me).

How to test the changes?

(Select all options that apply)

  • [x] I've included appropriate automated tests.
  • [ ] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

bernt-matthias avatar Mar 11 '24 12:03 bernt-matthias

ping @davelopez

bernt-matthias avatar Mar 11 '24 12:03 bernt-matthias

Also removes one test (test_xml_comments_are_ignored) which made no sense (to me).

I see your point. I cannot remember right now why I added this test. From the #14845 PR description, it sounded like the position (line and character offsets in the text document) of the issues reported by the linter will not match the real document if we have XML comments or additional spaces on it because they get removed by the parser before linting. But it looks like this will not prevent the parser from removing them anyway.

davelopez avatar Mar 11 '24 12:03 davelopez

This PR was merged without a "kind/" label, please correct.

github-actions[bot] avatar May 14 '24 15:05 github-actions[bot]